joakimp/mempalace-toolkit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(install): silence AWS probe when pi settings.json absent

Browse Source 
check_aws_env was warning about missing AWS_PROFILE/AWS_REGION even on
fresh machines with no settings.json yet \u2014 but at that point we don't
know which provider the user will pick, so the warning is noise.
check_pi_settings already tells the user to bootstrap settings.json;
the AWS probe now stays quiet until it has evidence (amazon-bedrock in
settings.json) that AWS creds are actually needed.
This commit is contained in:
Joakim Persson
2026-05-05 14:44:49 +02:00
parent 854ae41f65
commit 75876e5c41
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
install.sh
+5 -5
View File
@@ -327,11 +327,11 @@ check_aws_env() {
# Only warn if settings.json selects amazon-bedrock. If pi uses a # Only warn if settings.json selects amazon-bedrock. If pi uses a
# non-Bedrock provider (bare anthropic, openai, ...) AWS creds are # non-Bedrock provider (bare anthropic, openai, ...) AWS creds are
# irrelevant and this probe would be noise. # irrelevant and this probe would be noise. If settings.json doesn't
if [[ -f "$PI_SETTINGS_DEST" ]] \ # exist yet, check_pi_settings already told the user to bootstrap it
&& ! grep -q '"amazon-bedrock"' "$PI_SETTINGS_DEST" 2>/dev/null; then # — we can't know which provider they'll pick, so stay quiet here.
return 0 [[ -f "$PI_SETTINGS_DEST" ]] || return 0
fi grep -q '"amazon-bedrock"' "$PI_SETTINGS_DEST" 2>/dev/null || return 0
if [[ -n "${AWS_PROFILE:-}" && -n "${AWS_REGION:-}" ]]; then if [[ -n "${AWS_PROFILE:-}" && -n "${AWS_REGION:-}" ]]; then
ok "AWS env present (AWS_PROFILE=$AWS_PROFILE, AWS_REGION=$AWS_REGION)" ok "AWS env present (AWS_PROFILE=$AWS_PROFILE, AWS_REGION=$AWS_REGION)"