feat(pi): print and JSON mode skip the wake-up and mailbox poll (MEMPALACE_WAKEUP_PRINT=1 to keep them)

In print and JSON mode, `pi -p` and `--mode json` no longer get the
before_agent_start wake-up injection (status, diary and the tier-1 mailbox),
and the mid-session mailbox poll is off as well. The poll has its own guard,
not just `wokeUp`, because `pi -p -c` resumes and a resume sets wokeUp. The
client still connects, and the mempalace_* tools stay registered.
MEMPALACE_WAKEUP_PRINT=1 restores both. TUI and RPC sessions are unchanged.

Why: a one-shot run is a script asking one question. The wake-up cost it 12
palace calls and a large orientation message, and it is meant for the
operator of an interactive session. It can also do harm: on tor-ms22 a flash
model given "Reply with exactly: PONG" read the injected diary's open items
as its task, ran about 12 tool calls, and filed a wrong drawer in the shared
palace.

Measured on tor-ms22 (workspace copy, -ne -nt --no-session -e) with a fetch
probe that re-wraps pi's own fetch. The earlier preload-only fetch wrapper had
logged 0 lines in every run, because pi replaces globalThis.fetch.
- pi -p: 3 palace requests (initialize, initialized, tools/list), 1.6 s.
- --mode json: the same requests, 1.0 s, and no mempalace-wakeup in stdout.
- --mode json with MEMPALACE_WAKEUP_PRINT=1: 15 requests, 12 of them
  tools/call (status 1, diary 1, event_list 10), 3.6 s, and the wake-up is in
  stdout.

New scripts/test-wakeup-mode.sh has these cases: tui, print, json, print
resumed, tui resumed (a control that shows the poll does run), print with
MEMPALACE_WAKEUP_PRINT=1, and rpc. f590a3a's source fails the print, json and
print-resumed cases, with 12, 12 and 5 calls. All seven scripts/test-*.sh
pass.
This commit is contained in:
2026-10-13 15:32:07 +02:00
parent f590a3ac5b
commit d5a03f4ff5
3 changed files with 192 additions and 2 deletions
+23
View File
@@ -38,6 +38,9 @@ dependencies (~300 MB).
injects the result as a `mempalace-wakeup` system message so the
agent orients itself the way `~/.agents/skills/mempalace/SKILL.md`
describes. Skipped on resume/fork (context is already in the thread).
Also skipped in print and JSON mode (`pi -p`, `--mode json`), together
with the mid-session mailbox poll, unless `MEMPALACE_WAKEUP_PRINT=1`.
See [Debugging](#pi--p-prints-its-answer-then-takes-minutes-to-exit).
4. **Automatic transcript feeding** (`session_shutdown`, and a debounced
`agent_settled`): stages + mines this pi installation's own session
transcripts into the palace with no user action needed — **as of
@@ -116,6 +119,7 @@ side of the wiring.
|---|---|---|
| `MEMPALACE_FEED` | `1` | Set `0` to disable automatic feeding entirely. |
| `MEMPALACE_FEED_PRINT` | unset | Set `1` to feed in print and JSON mode too (`pi -p`, `--mode json`). They skip the feed by default, because the next interactive session's feed files the same sessions without duplicates. See [Debugging](#pi--p-prints-its-answer-then-takes-minutes-to-exit). |
| `MEMPALACE_WAKEUP_PRINT` | unset | Set `1` to keep the wake-up injection and the mid-session mailbox poll in print and JSON mode. They are skipped there by default. The `mempalace_*` tools stay registered either way. |
| `MEMPALACE_FEED_BIN` | `mempalace-pi-session` | Helper to run. |
| `MEMPALACE_FEED_WING` | `wing_conversations` | Target wing — passed to both the exporter and the `mempalace_mine` call. |
| `MEMPALACE_FEED_DEBOUNCE_MS` | `600000` (10 min) | Minimum gap between mid-session (`agent_settled`) feeds. Bounds crash loss to one window instead of a whole session. |
@@ -608,6 +612,25 @@ skips an unchanged file, and for a grown file it purges that file's drawers
before refiling. A device that only ever runs `pi -p` sets
`MEMPALACE_FEED_PRINT=1`, or its transcripts are never fed.
**Print and JSON mode skip the wake-up too (also 2026-10-13).** The wake-up
injection costs 12 palace calls: `mempalace_status`, `mempalace_diary_read`,
and 10 `mempalace_event_list` for the tier-1 mailbox. It also adds a large
orientation message to a script's one question. It is meant for the operator
of an interactive session, who sees the same thing in their next one. It can
also do harm. In one tor-ms22 probe, a flash model was given
`Reply with exactly: PONG`. It read the injected diary's open items as its
task, ran about 12 tool calls, and filed a wrong drawer in the shared palace.
So in print and JSON mode the bridge now skips the injection. It also skips
the mid-session mailbox poll, through its own guard: `pi -p -c` resumes, and a
resume sets the flag the poll would otherwise use. The client still connects
and the `mempalace_*` tools stay registered, so a prompt that asks for the
palace gets it. Measured on tor-ms22 with a fetch probe that re-wraps pi's
own `fetch`: `pi -p` made 3 palace requests (`initialize`, `initialized`,
`tools/list`) and exited in 1.6 s. With `MEMPALACE_WAKEUP_PRINT=1` it made 15,
including 12 `tools/call`, and the wake-up appeared in the JSON stream.
`scripts/test-wakeup-mode.sh` pins it; `f590a3a`'s source fails its print,
json and print-resumed cases.
## The `Type.Unsafe` gotcha
Earlier versions of this extension registered every MCP tool with
+19 -2
View File
@@ -20,7 +20,8 @@
* - Wake-up (auto): on first user prompt of a fresh session, inject
* `mempalace_status` + `mempalace_diary_read` output as context so the
* agent orients itself the way the mempalace skill describes. Skipped
* on resume/fork (palace context is already in the thread).
* on resume/fork (palace context is already in the thread), and in
* print/json mode (`pi -p`, `--mode json`) unless MEMPALACE_WAKEUP_PRINT=1.
* - Feeding (auto): stage + mine this container's pi transcripts into the
* palace on `session_shutdown` and on a debounced `agent_settled`. Needs
* no LLM turn (pi transcripts are JSONL on disk), which is why it CAN be
@@ -1200,6 +1201,19 @@ export default async function mempalaceExtension(pi: ExtensionAPI) {
};
const feedsThisRun = (ctx: unknown): boolean => feedInPrintMode || !isOneShot(ctx);
// Print and JSON mode skip the palace start-up work as well, unless
// MEMPALACE_WAKEUP_PRINT=1. That is the wake-up injection (status + diary +
// tier-1 mailbox) and the mid-session mailbox poll. A one-shot run is a
// script asking one question. The wake-up costs it several palace round
// trips and a large orientation message, and it serves the operator of an
// interactive session, who sees it next time they open one. It can also do
// harm: on tor-ms22 a flash model given "Reply with exactly: PONG" read the
// injected diary's open items as its task, ran ~12 tool calls, and filed a
// wrong drawer. The mempalace_* tools stay registered, so a prompt that asks
// for the palace still gets it.
const wakeupInPrintMode = process.env.MEMPALACE_WAKEUP_PRINT === "1";
const wakesThisRun = (ctx: unknown): boolean => wakeupInPrintMode || !isOneShot(ctx);
// Mid-session feed. A hard container kill runs no handler at all, so this is
// what bounds crash loss to one debounce window instead of a whole session.
// Re-mining a grown transcript purges and refiles that source_file, so
@@ -1675,6 +1689,8 @@ export default async function mempalaceExtension(pi: ExtensionAPI) {
pi.on("agent_settled", async (_event, ctx) => {
if (!mailboxEnabled || !available) return;
// Explicit, not left to `wokeUp`: `pi -p -c` resumes, which sets wokeUp.
if (!wakesThisRun(ctx)) return;
if (!wokeUp) return; // the wake-up injection has not run yet; it does look #1
if (Date.now() - lastMailboxPollAt < mailboxPollMs) return;
// Claim the slot BEFORE awaiting anything, so overlapping settles cannot
@@ -1759,8 +1775,9 @@ export default async function mempalaceExtension(pi: ExtensionAPI) {
});
// --- Auto wake-up (mempalace skill Phase 1) ---
pi.on("before_agent_start", async (_event, _ctx) => {
pi.on("before_agent_start", async (_event, ctx) => {
if (wokeUp || !available) return;
if (!wakesThisRun(ctx)) return; // one-shot run: see wakesThisRun
wokeUp = true; // one-shot, even if the calls below fail
const sections: string[] = [];