From 4efc4e8005b0d1d36eea967c051bb2daf7d87934 Mon Sep 17 00:00:00 2001 From: Joakim Persson Date: Tue, 28 Apr 2026 06:53:44 +0000 Subject: [PATCH] Remove dead INSTALL_PYTHON build arg MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Python 3 has been unconditionally present since the Debian trixie upgrade (e58962a, Apr 13) — python3 3.13 ships as a transitive dependency of the trixie base image. python3-pip (e1029bb) and python3-venv (3a7ec45) were later added to the base layer on Apr 23 so Mason could install Python-based LSPs (ruff, ansible-lint) into venvs on nvim startup. MemPalace's pip install (b9c08c3) just piggybacks on what was already there. In other words, INSTALL_PYTHON=true has been a no-op reinstall of already-installed packages for two weeks before MemPalace existed. The flag is dead weight and the docs that advertise it as meaningful are misleading. Remove it everywhere. Users who want Python tooling should use the pre-installed uv/uvx. --- .gitignore | 4 ++++ CHANGELOG.md | 4 ++++ DOCKER_HUB.md | 1 - Dockerfile | 10 +--------- README.md | 3 +-- docker-compose.yml | 1 - 6 files changed, 10 insertions(+), 13 deletions(-) diff --git a/.gitignore b/.gitignore index d7f88cd..690c761 100644 --- a/.gitignore +++ b/.gitignore @@ -9,3 +9,7 @@ # Personal cloud-init overrides (not shared) deploy/my-cloud-init.yml + +# MemPalace per-project files (issue #185) +mempalace.yaml +entities.json diff --git a/CHANGELOG.md b/CHANGELOG.md index ac1a441..fcc122e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,10 @@ Tags follow `v{opencode_version}[letter]` — bare tag for the first build on a --- +## Unreleased + +- **Cleanup:** Remove dead `INSTALL_PYTHON` build arg. Python 3 + pip + venv have been unconditionally installed in the base layer since mempalace was added; the flag was a no-op. Users should use `uv` (pre-installed) or `uvx` for Python tooling. + ## v1.14.28b — 2026-04-27 - **Feature:** Add MemPalace local-first AI memory system to base image. Provides 29 MCP tools for semantic search over conversation history, knowledge graph queries, and agent diaries. Palace data persists via optional `devbox-palace` named volume, ChromaDB embedding model cache via `devbox-chroma-cache`. No API keys required. diff --git a/DOCKER_HUB.md b/DOCKER_HUB.md index 045eae3..7921cd4 100644 --- a/DOCKER_HUB.md +++ b/DOCKER_HUB.md @@ -520,7 +520,6 @@ Everything in the base image, plus: When [building from source](https://gitea.jordbo.se/joakimp/opencode-devbox), additional runtimes are available via build args: -- **Python 3** (`INSTALL_PYTHON=true`) — Python 3 + pip + venv - **Go** (`INSTALL_GO=true`) — Go toolchain ## oh-my-opencode-slim (OMOS variant) diff --git a/Dockerfile b/Dockerfile index bae2607..f8faeb6 100644 --- a/Dockerfile +++ b/Dockerfile @@ -160,15 +160,7 @@ RUN ARCH=$(case "${TARGETARCH}" in \ unzip -q /tmp/awscli.zip -d /tmp && \ /tmp/aws/install && \ rm -rf /tmp/aws /tmp/awscli.zip && \ - aws --version - -# ── Optional: Python ───────────────────────────────────────────────── -ARG INSTALL_PYTHON=false -RUN if [ "${INSTALL_PYTHON}" = "true" ]; then \ - apt-get update && apt-get install -y --no-install-recommends \ - python3 python3-pip python3-venv && \ - rm -rf /var/lib/apt/lists/*; \ - fi + aws --version # ── Optional: Go ───────────────────────────────────────────────────── ARG INSTALL_GO=false diff --git a/README.md b/README.md index 6eec796..65c07c5 100644 --- a/README.md +++ b/README.md @@ -330,13 +330,12 @@ docker compose run --rm --build devbox Enable optional language runtimes or pin a specific opencode version: ```bash -docker compose build --build-arg INSTALL_PYTHON=true --build-arg INSTALL_GO=true +docker compose build --build-arg INSTALL_GO=true docker compose build --build-arg OPENCODE_VERSION=1.5.0 ``` | Arg | Default | Description | |---|---|---| -| `INSTALL_PYTHON` | `false` | Python 3 + pip + venv | | `INSTALL_GO` | `false` | Go toolchain | | `INSTALL_OMOS` | `false` | [oh-my-opencode-slim](https://github.com/alvinunreal/oh-my-opencode-slim) multi-agent orchestration (installs Bun and plugin) | | `OMOS_VERSION` | `latest` | Pin a specific oh-my-opencode-slim version | diff --git a/docker-compose.yml b/docker-compose.yml index 29b4e5f..e8ec1a1 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -23,7 +23,6 @@ services: # build: # context: . # args: - # INSTALL_PYTHON: "false" # INSTALL_GO: "false" # INSTALL_OMOS: "false" container_name: opencode-devbox