198 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Joakim Persson	42bd29d654	fix(ci): unblock the release — npm 11 esbuild bloat + two self-inflicted assertions ... v1.9.0 was tagged but never published: smoke failed 90-passed/3-failed and build-variant needs smoke, so nothing reached the registry. All three are fixed. 1. Size, 431 MB over threshold. Node 24 brings npm 11, which installs EVERY @esbuild/<platform> optional binary instead of the matching one: 26 dirs, 284 MB per pi-coding-agent copy. Measured on pi-fork: npm 10.9.8 -> 165 MB (exactly what v1.8.14 shipped), npm 11.19.0 -> 449 MB. npm 11 ignores the os/cpu constraints AND --os/--cpu AND an npmrc carrying them, all measured, so Dockerfile.variant prunes explicitly, keeping linux-$(node -p process.arch) so one line is right on both arches. Pruned in the SAME layer as each install, or the bytes survive in the earlier layer. Three sites: global pi, pi-fork, pi-studio. Verified esbuild still transforms TS after. 2. om's node_modules assertion tested an npm artefact. om has zero runtime deps; its node_modules held ONE file (.package-lock.json) and 20 empty scope dirs. npm 11 stopped creating it. Now asserts the entry point pi actually loads, read from package.json -> pi.extensions. 3. The skill-source annotation added in v1.9.0 ("baked (package copy)") broke the assertion matching "baked$". Pattern now allows an optional suffix; which copy shipped stays authoritatively asserted against the manifest + tree hash. Also: a failed size check now prints the largest layers, largest directories and an @esbuild sentinel, so this class attributes itself next time instead of costing a CI dig plus a local npm bisect. Threshold stays 3800 MB: it caught a real regression and raising it would have thrown the signal away. No Dockerfile.base/rootfs change, so base-0fb1256c7f99 is reused and build-base is skipped. v1.9.1	2026-09-10 23:39:40 +02:00
Joakim Persson	3a44e81cad	feat(ci): gate documentation drift, and make docs a pre-tag release step ... Five doc claims had rotted by v1.9.0, all the same shape: a value written once by hand, in a file nothing verifies, about a number that lives elsewhere and moved. README pin table wrong on all three rows; a "Planned" section describing something already shipped; DOCKER_HUB.md claiming Node v22 against Node 24. DOCKER_HUB.md is why this is a gate and not a resolution to be careful: it is PUBLISHED (update-description POSTs it as Docker Hub full_description on every tag), it had gone eight releases untouched, nothing generates it, and it is read from the TAG -- so the stale page shipped with v1.9.0 regardless. scripts/check-doc-drift.sh: seven checks, all repo-local (no network, token, image, or sibling clone). Exit 0/1/2 matching lint-shell.sh; a renamed ARG is a red 2, not a green tick. Wired as a fourth lint.yml job so "the docs lie" is its own red name. Verified with 15 controls, including two false-positive controls: the first placeholder check flagged README.md:900, a Go template in a legitimate `docker inspect --format` example. The gate was wrong, not the doc, so the pattern is now anchored to the UPPER_SNAKE convention CI substitutes. Not gated, deliberately: counts/sizes needing a running image (they belong in smoke-test.sh -- a guessing gate is worse than none), and Dockerfile.base BASE_REBUILD_DATE, because base_tag hashes that file content-wise and demanding it be current would force a ~60 min rebuild on releases that touch no base files. Free during a rebuild, expensive otherwise. AGENTS.md step 3 rewritten around the mechanism: checkout@v4 with no ref: means every job reads github.ref, the tag. Docs must be right BEFORE tagging.	2026-09-10 22:01:49 +02:00
Joakim Persson	35964abd01	docs(hub): the Docker Hub page claimed Node v22; v1.9.0 ships Node 24 ... DOCKER_HUB.md is hand-maintained (no generator: CI only substitutes {{PI_VERSION}} and POSTs the file as Docker Hub full_description), and it was last touched at v1.8.6 -- eight releases ago. The Node claim is now false as of this release, and unlike README.md this file IS published, so a stale claim here is user-visible rather than internal. Verified countable claims rather than assuming: "7 user-facing extensions" is correct (7 files in pi-extensions/extensions/). The "29 mempalace_* tools" claim is suspect -- this session sees 45 -- but left alone because I cannot attribute that count to the baked 3.9.0 server without measuring it.	2026-09-10 21:43:17 +02:00
Joakim Persson	6353d59e63	docs(readme): correct the three stale version pins and the shipped-as-planned claim ... The version-pin table existed precisely to be the reviewable record of what is deliberately frozen, and it was wrong on every row: pi 0.84.4 -> 0.85.1, pi-atelier v0.10.0 -> v0.10.1, mempalace 3.8.0 -> 3.9.0. Verified by parsing the table and comparing against the ARGs it names rather than by eye. Also: the "Planned for an upcoming minor release" section listed typst PDF export, which shipped long ago and even carried a self-contradicting "(shipped in Unreleased/base)" marker -- the fourth instance of the stale in-repo Unreleased-pointer class this CHANGELOG already documents. typst 0.15.1 confirmed live in the running image, so the item is now stated as current fact. The pi-devbox-version sample was v1.5.0-era and structurally outdated: it predates the palace line the surrounding prose advertises, the pi-atelier component, and the whole skills: block. Replaced with real observed output rather than hand-written text. README has no CI coupling (no workflow or gate reads it; the Docker Hub page comes from DOCKER_HUB.md), so this cannot affect the in-flight v1.9.0 build.	2026-09-10 21:33:07 +02:00
Joakim Persson	8f0960e134	release: v1.9.0 ... Rename the Unreleased changelog section to its release heading, matching the established `## vX.Y.Z — YYYY-MM-DD` format (em dash), per AGENTS.md release step 3. Minor rather than patch: CHANGELOG.md scopes minor to "significant base additions", and this release bumps the Node runtime under every baked JS tool (pi, agent-browser, playwright, mempalace) from 22 to 24 — the first NODE_VERSION change since it was introduced at v1.0.0 — alongside five new base packages (shellcheck, bind9-dnsutils, ldap-utils, xxd, python3-yaml). Package additions alone have been patch here (v1.8.12, v1.8.13); the runtime major is what lifts this one. v1.9.0	2026-09-10 21:21:09 +02:00
Joakim Persson	1c905480e3	docs(changelog): note the mempalace feed-tick fix this image carries ... The recurring "[mempalace ext] feed (tick) failed: mine timed out after 30000ms" message is fixed in mempalace-toolkit (309980b + e68ee20) and this image is what delivers it, since CI resolves MEMPALACE_TOOLKIT_REF to a commit SHA at build time. Worth a changelog entry rather than leaving it implicit in a ref bump: it is the most visible symptom operators on this fleet have been living with, and the entry records that it was a genuine defect (overlapping mines on a single-writer palace) rather than the cosmetic annoyance it was parked as.	2026-09-10 20:58:42 +02:00
Joakim Persson	ff6fd1492a	feat(manifest): record WHICH pi-extensions skill copy shipped ... Closes the half deliberately left open by cac5e00's skill-floor gate, and the more important half: "the floor is currently fresh" is a fact with a shelf life, whereas "the image says which copy it got" keeps working. The refresh in Dockerfile.variant is guarded by `[ -f /opt/pi-extensions/skill/SKILL.md ]`, so a build whose clone predates the co-located skill keeps the vendored floor and still succeeds GREEN, with nothing in the manifest, labels or logs separating that from a normal build. Afterwards the two are indistinguishable by inspection -- same path, same filenames, same permissions -- which is exactly how the floor went unnoticed from 2026-07-30 to 2026-09-10. build-manifest.json gains pi_extensions_skill_source and pi_extensions_skill_tree_sha256, MEASURED rather than passed as build-args, per the ground-truth rule the surrounding block already follows -- and necessarily so, since the outcome depends on the clone's contents and no ARG could express it. Three values, because two would force a lie: package (served bytes equal the clone's skill/), vendored-floor (clone had no skill/ at this ref), and divergent (both exist but differ -- e.g. the clone ships SKILL.md but not evaluate-extension-usage.py, so the served directory is a genuine MIX). No OCI label mirrors these deliberately: LABEL cannot take a RUN-computed value, and a label fed from an ARG would be the claim-not-measurement being removed here. Two smoke assertions make the record a gate: the source must be named and be `package` -- vendored-floor FAILS rather than warns, since these images track main where the package has shipped skill/ since fa04d20, so a fallback means the clone did not resolve as intended -- and the tree hash is recomputed over the served directory, because a recorded hash never recompared is a claim. pi-devbox-version annotates the line too: "baked (package copy)" normally, or a yellow "(FALLBACK: vendored floor)". Its existing section reports which copy is READ at runtime; this is the one fact decided at BUILD time and unrecoverable later. Old images degrade cleanly -- field absent, jq // empty yields nothing, line prints plain "baked" as before (verified against this v1.8.14 manifest). Tested by running the exact logic against this container's real layout, with the expected value written down before each: package (served == clone), vendored-floor (clone path absent), divergent (clone lacking the .py while the served dir has it), and null (empty served dir) -- all four as predicted. The five pi-devbox-version render branches likewise, including the absent-field case. Emitted JSON validated with jq for both the populated and null forms. Gates green: lint-shell.sh (15 files), hadolint 2.15.1, actionlint 1.7.12, check-base-hash.sh, check-skill-floor.sh, vendor-mempalace-skill.sh --check.	2026-09-10 20:30:16 +02:00
Joakim Persson	edc7659add	chore(deps): node 22->24, actionlint 1.7.12, hadolint 2.15.1, skillset ref ... Audited every component the image obtains OUTSIDE debian/apt. Of ~23, the 19 that resolve `latest` at build time were already current or refresh themselves on the next rebuild, and the hard pins for pi (0.85.1), mempalace (3.9.0) and pi-atelier (v0.10.1) were already newest. Four needed a human. NODE_VERSION 22 -> 24 (LTS "Krypton"). This was a latent defect rather than housekeeping: agent-browser publishes engines.node ">=24.0.0", so the image sat BELOW a declared requirement -- v1.8.14 shipped node 22.23.2 with agent-browser 0.37.1, so every build installed it with an npm EBADENGINE warning and ran the baked browser automation outside its supported range. pi (">=22.19.0") and playwright (">=20") are satisfied either way. Verified before bumping, since a missing NodeSource suite breaks every arch at once: setup_24.x returns HTTP 200 and node_24.x advertises `Architectures: amd64 arm64 armhf x86_64`, covering the arm64 fleet and the amd64 CI runners. Nothing else pinned the node major. actionlint 1.7.7 -> 1.7.12 and hadolint 2.14.0 -> 2.15.1, each RUN AGAINST THIS TREE at the new version before being pinned -- both clean, no new findings. A linter bump is the one dependency update that can turn CI red on unchanged code, so it is verified locally rather than discovered on a round trip. SKILLSET_SNAPSHOT_REF e9e09d9 -> 4d7c0ea via scripts/vendor-mempalace-skill.sh, never by hand: that script is the only thing permitted to write the ARG, because a cp without a matching bump yields a manifest that confidently lies. This proved PROVENANCE-ONLY -- the ref was 6 commits behind, but skills/mempalace/SKILL.md is byte-identical at both (3675bfab), so the snapshot was already correct and only its recorded origin was stale. No rootfs/ bytes changed, the smoke-test phrase canary stays valid, and this ARG alone would not force a base rebuild (the node bump does). Two measurement traps worth recording, since both would have produced a wrong answer: GitHub's releases/latest reports pi-atelier v0.10.0 as newest because v0.10.1 is a TAG WITH NO RELEASE OBJECT -- the pin was already current, and `git ls-remote --tags` is the instrument that shows it. And gitea-mcp is hosted on gitea.com, not GitHub, so querying api.github.com returned nothing at all rather than an error. Verified with every gate this repo owns, all green, using the NEW linter pins: lint-shell.sh (15 files), check-workflow-shell.sh, check-base-hash.sh, actionlint 1.7.12, hadolint 2.15.1, check-skill-floor.sh, and vendor-mempalace-skill.sh --check.	2026-09-10 20:17:32 +02:00
Joakim Persson	cac5e00a31	feat(ci): gate the vendored pi-extensions skill floor, and bake python3-yaml ... Follows ecfd2fc, which refreshed the stale floor by hand. A one-off refresh fixes the symptom; this makes the drift impossible to reintroduce silently. scripts/check-skill-floor.sh compares the repo floor (rootfs/usr/local/share/pi-devbox/skills/pi-extensions/) against the package repo it is a snapshot of, wired in as a new `skill-floor` job in lint.yml. DIRECTORY hash, not `sha256sum SKILL.md`, using the same tree_sha256 pipeline Dockerfile.variant uses for skillset_snapshot_tree_sha256 and for the reason already documented there: a file-only compare answers "did this one file change", not "is this the same skill". Verified by NEGATIVE CONTROL rather than asserted -- with SKILL.md left byte-identical and only evaluate-extension-usage.py edited, the directory check fails (rc=1) where a file-only compare would have passed. Seven behaviour tests, each with its expected rc written down before running: in-sync via local dir (0), in-sync via anonymous remote clone (0), missing --package-dir (2), bad argument (2), content drift (1), the sibling-file case (1), and --warn-only over drift (0). Exit codes 0 in sync / 1 drift / 2 cannot-run, matching scripts/lint-shell.sh: a gate that cannot run must not pass, so an unreachable package repo is a red 2 and never a green tick. A ref with no skill/ is NOT drift -- that is the documented fallback -- but it emits ::warning:: because it is precisely the condition under which the floor ships. Gating on another repo is normally a smell. It is proportionate here because the check can only fire when skill/ itself changed, which is exactly when the floor has gone stale; pi-extensions commits that leave skill/ alone cannot turn this red. It also needs no secret: pi-extensions is anonymously clonable (verified with `git ls-remote` and no credentials), so it cannot start failing when a token expires. Also bakes python3-yaml (552 KB, zero extra deps) into Dockerfile.base. This is the shellcheck story repeating exactly: scripts/check-workflow-shell.sh -- the guard against the Gitea sh/dash footgun that broke resolve-versions (ed49b8d) and promote-base-latest (b7197e8) -- hard-exits with "python3 yaml module missing", so a gate this repo already owns could not be run locally by anyone. lint.yml installing it explicitly in CI was the evidence. Found while wiring the job above: the guard could not be run before pushing. CHANGELOG Unreleased updated for both this and ecfd2fc, including an explicit note on what is NOT fixed -- the silent-fallback half still has no manifest flag recording which copy was served. Verified locally with every gate this repo owns, all green: lint-shell.sh (15 files clean), check-workflow-shell.sh, check-base-hash.sh, actionlint 1.7.7 (pinned, same version as CI), hadolint 2.14.0, and the new check itself.	2026-09-10 19:14:01 +02:00
Joakim Persson	ecfd2fc2e5	feat: bake dig/ldapsearch/xxd and refresh the stale pi-extensions rootfs floor ... Two changes that share one forced base rebuild, hence one commit. 1. THREE PACKAGES, each closing a capability gap measured during the gitea.egl.lan/FreeIPA work on 2026-09-09..10 rather than a preference: bind9-dnsutils (~6.1 MB measured) -- dig/host/nslookup were ALL absent, so the container could resolve names but had no way to interrogate a SPECIFIC nameserver. `getent hosts` only follows the resolver's default path, so diagnosing "gateway 172.16.88.1 NXDOMAINs the egl.lan zone while 10.20.253.1 is authoritative for it" had to be hand-rolled in python3. Split-horizon DNS is a recurring class of bug on this fleet. Note the package name: plain `dnsutils` is transitional in trixie. ldap-utils (1244 KB, pulls nothing extra) -- the fleet authenticates against FreeIPA, yet every LDAP probe had to be run by SSHing to an already-enrolled host. Simple binds only; GSSAPI would additionally need krb5-user + libsasl2-modules-gssapi-mit, deliberately not added as that is a Kerberos-client decision, not a tool. xxd (198 KB) -- convenience for verifying git-crypt blob magic in myconfigs; `od -c` from coreutils already does the same job. netcat-openbsd was in the original proposal and is deliberately NOT here: measured redundant, because socat is already baked and bash's /dev/tcp does reachability checks with zero packages (verified against gitea.egl.lan:3000). Recorded in the Dockerfile so the omission reads as a decision rather than an oversight. 2. ROOTFS FLOOR REFRESH: rootfs/.../pi-extensions/SKILL.md was 34284 B, unchanged since fa04d20 (2026-07-30), while the canonical package copy is 38973 B. Dockerfile.variant copies the fresh package copy over the SERVED path at build time but never writes back to this floor, so the floor is a silent fallback: if that build-time copy is ever absent it ships the July skill with no log line or manifest flag to say which version deployed. Refreshed from pi-extensions@c64c122, verified byte-identical to both the canonical and the runtime-served copies. Why one commit: the base_tag hash folds in `cat Dockerfile.base` AND `find rootfs -type f | xargs cat` (.gitea/workflows/docker-publish.yml), so either change alone forces the same full base rebuild -- and that rebuild is precisely what re-bakes rootfs/ as it then stands. Emulating the workflow hash with a fixed toolkit ref: f3d6462c7416 -> fc4edda03c54. Verified: scripts/check-base-hash.sh passes (no new ARG *_REF added), and no shell scripts are touched so the lint-shell gate is unaffected. Sizes and dependency fan-out measured via apt-get --no-install-recommends --dry-run on Debian 13 trixie.	2026-09-10 18:56:11 +02:00
joakimp	15a3728ae9	feat: bake shellcheck and add a client-side pre-push lint gate ... v1.8.14 made shell lint a RELEASE gate (scripts/lint-shell.sh, shared by lint.yml and the new lint-gate job that resolve-versions depends on), and that script correctly exits 2 when shellcheck is absent -- "a gate that cannot run must not pass". Measured on v1.8.14 on 2026-09-09 by three routes (command -v, dpkg -l, a filesystem search): shellcheck was NOT IN THE IMAGE AT ALL. So the gate could not be run by a developer in any container, only in CI, and the loop stayed write-shell -> push -> wait for CI -> discover. That is the loop the gate was added to shorten, after v1.8.14's first attempt burned ~46 min on a tree whose lint had already been red for 24 hours. shellcheck 0.10.0-1 added to the Dockerfile.base apt block: ~39 MB installed (Installed-Size 40112 KB), measured to pull ZERO additional packages under --no-install-recommends because libc6/libffi8/libgmp10 are already present. NOTE this forces one full base rebuild -- base-decide hashes Dockerfile.base + rootfs/, so unlike a scripts/ change it cannot reuse the existing base- layer. hooks/pre-push is opt-in per clone (git config core.hooksPath hooks), bypassable with --no-verify, and execs scripts/lint-shell.sh rather than reimplementing it -- one copy, because a duplicated check that drifts is the failure this repo keeps paying for. Matches the idiom skillset/ and myconfigs/ already use. WHY THIS REPO HAD NO HOOKS, since it was reported as drift and is not: a peer asked tor-ms22 for core.hooksPath per clone on the premise that unset meant the gates were unverified there. Measured: pi-devbox unset, skillset hooks, myconfigs common/hooks, pi-toolkit unset -- but `git ls-files | grep -i hook` is EMPTY in both pi-devbox and pi-toolkit, so there was nothing to point at on any machine and unset was the only correct value. This closes the real half for pi-devbox; pi-toolkit still ships none. Verified, expected result written down before each check: * refusal paths -- shellcheck absent => rc 2 with the remedy named; linter missing => rc 2. Never waved through on the assumption CI will catch it. * the hook is IN the scan set -- "Checking 14 shell file(s)" with it present, 13 with it moved aside, so the extensionless file is found by the shebang half of the linter's two-signal union. This check exists because the first attempt was ambiguous: a planted `[ $UNSET_VAR = "x" ]` was not reported, which could equally have meant "not scanned" or "below -S error". It was the latter. A count that moves is unambiguous; a clean run is not. * it catches the REAL v1.8.14 defect -- planting `echo 'the fleet\'s thing'` in hooks/pre-push yields SC1073/SC1072 at severity error, rc=1. And the gate earned its keep inside this commit: the first version of the smoke-test assertion carried a comment beginning "# shellcheck is a GATE DEPENDENCY", and a comment whose first word is the tool's name is parsed as a DIRECTIVE, not a comment. The new gate failed it with SC1073/SC1072 before the push -- same family as the v1.8.14 apostrophe, a line that reads as prose to a human and as syntax to the parser.	2026-09-09 08:57:34 +02:00
joakimp	361babd4fd	ci: gate the release on shell lint, from one shared script ... v1.8.14's first attempt spent ~46 minutes building a base image for a tree whose own lint had been failing for 24 hours. shellcheck had already flagged the defect (SC2289, severity error) on the push that introduced it; the lint workflow went red at run 186 and nobody read it. lint.yml deliberately skips tag pushes and its reasoning is sound -- the tagged tree was already linted on main, and a tag-ref lint run sorts above the publish run, making a release look finished before anything ships. The missing invariant was never "lint the tag". It was "do not RELEASE a tree whose lint failed", and only a job inside the publish workflow can enforce that. So: extract the shell-lint logic from lint.yml into scripts/lint-shell.sh and call it from both places, then add a lint-gate job that resolve-versions depends on. resolve-versions is the graph root, so gating it gates everything. Cost is ~40 s at the front of a release; the alternative already cost fifty minutes. Extracted rather than copied on purpose. A second copy of a check is the drift this repo keeps paying for -- the same evening produced a skillset mirror that had sat 9579 B behind its upstream through two consecutive edits. The script adds one behaviour the inline version lacked: if shellcheck is not installed it exits 2 rather than silently finding nothing, inheriting the existing "a gate that cannot run must not pass" rule from hooks/pre-commit in the skillset repo. Without that, reordering the install step away would turn the gate into a green tick over zero checks. Verified locally with a stubbed shellcheck (the real binary is not in the devbox), five cases, each with its expectation stated first: absent shellcheck -> rc=2; stub pass -> rc=0 and a non-zero file count; stub fail -> rc=1; a deliberately unterminated `if` planted in scripts/ -> rc=1 via the bash -n half, naming the file; removal -> rc=0 again. Discovery cross-checks against CI's own number: the inline version reported 12 files, the extracted one reports 13, the difference being lint-shell.sh itself. YAML re-parsed (10 jobs, was 9) with an assertion that resolve-versions needs lint-gate, and the repo's check-workflow-shell.sh guard still passes. v1.8.14	2026-09-08 23:41:44 +02:00
joakimp	70e675afee	fix(smoke): keep prose out of the single-quoted exec_test body ... The agent-browser execution guard added on 2026-09-07 carried its explanation INSIDE the single-quoted script body, and the explanation contained an apostrophe ("the fleet\'s only recurring amd64 runtime proof"). Inside '...' bash treats a backslash as literal, so \' does not escape the quote -- it CLOSES the string. The body truncated at that point and the remaining lines were parsed by the calling shell. Consequences, both measured rather than inferred: - exec_test received 12 arguments instead of 2 (verified two-sided: the fixed tree yields argc=2, HEAD yields argc=12). - the leaked `v=$(agent-browser --version)` ran on the CI RUNNER instead of inside the image. The runner has no agent-browser, so smoke and smoke-studio both failed with "line 770: command not found" after build-base had already spent ~46 minutes. Every downstream job was skipped. - the truncated body still passed inside the container and printed its green tick first, so the log shows a PASS immediately followed by the failure -- the tick was real, it just no longer covered the assertion. The prose now sits above the exec_test call, where an apostrophe cannot terminate anything, and a comment at that spot records why it must stay there. Not a new failure class: shellcheck flagged it as SC2289 at severity error the same day, so the lint job has been red since run 186 (2026-09-07 21:21) and was not read. The gate did its job; nobody looked.	2026-09-08 23:31:48 +02:00
joakimp	601fc98a49	docs(changelog): release v1.8.14 ... Converts the Unreleased section and records what this build carries beyond it: the mempalace-toolkit bump that makes closing replies reach the mailbox (deriveClosed, 21023e7 -> e45f6b4), and the L0-L4 subtask documentation landing via pi-toolkit adfb553 + pi-extensions c64c122. Notes the mechanism that makes the toolkit fix land at all — the resolved toolkit SHA is folded into the content-addressed base tag, so the toolkit moving forces a base rebuild rather than waiting for one — and the consequence for the amd64 item already in this section: v1.8.13's base was cached, so Dockerfile.base:607's agent-browser assertion never ran. This base is not cached, so the native-amd64 proof is finally collected instead of discarded.	2026-09-08 22:09:31 +02:00
joakimp	7e0e66997d	docs(env): name MEMPALACE_MAILBOX_NOTIFY — auto-detect cannot work in a container ... Unset means the mailbox is silent outside the pi TUI, and the reason is structural: docker exec does not forward KITTY_WINDOW_ID/TERM_PROGRAM, so 'desktop' detection always falls through to OSC 777, which Kitty does not implement — the notification then silently does nothing, the worst failure for a feature whose only job is to break a silence. Documents the four modes, and that MEMPALACE_MAILBOX_POLL_MS is a FLOOR BETWEEN activity-coupled polls rather than a wall-clock interval (an idle session polls zero times) — the exact expectation mismatch reported today.	2026-09-07 21:43:01 +02:00
joakimp	6bd8b79d3a	test(smoke): assert agent-browser EXECUTES — it was the discarded amd64 proof ... Second instance of the same bug class as the node line, in the same file, found the same way. The agent-browser guard captured the version inside an echo with 2>/dev/null: echo "resolved=[$r] version=[$(agent-browser --version 2>/dev/null|head -n1)]" >&2 so the exit code was discarded and a binary that could not execute at all still PASSED, printing version=[]. Verified two-sided: a stub exiting 127 passes the old form and is caught by the new one. Why this exit code matters more than most: smoke runs platforms: linux/amd64 on an x86 runner, i.e. NATIVE amd64, so this line is the fleet's only recurring amd64 runtime proof for agent-browser's linux-x64 ELF. NO DEVBOX CAN EVER SUPPLY THAT PROOF. Every machine in the pi fleet is an Apple Silicon Mac: mbp-m1-2020; tor-ms22 = Mac Studio Mac13,1 M1 Max (fleet-ops hosts/tor-ms22.md, verified 2026-08-17 with system_profiler); emb-7kj4vr4g = Apple Silicon, verified 4 routes 2026-09-07. The open "amd64 runtime proof still needed" ask sent to two devices was asking for the impossible, and emb's reply naming tor-ms22 as "the only remaining candidate" is wrong for the same reason. CI had the answer all along and was throwing it away. Dockerfile.base:607 DOES assert it (`agent-browser --version && \`), but only when the base rebuilds, and v1.8.13's base was cached — so smoke is where the recurring gate belongs.	2026-09-07 21:21:16 +02:00
joakimp	fabf1274aa	docs(changelog): Unreleased section for the smoke node assertion + agent-browser correction ... Summarises what changed since v1.8.13: the node-major assertion (a bump would have passed the suite silently), the two-sided verification of the derivation, and the v1.8.13 agent-browser 0.35.2 -> 0.36.0 correction. No image content changes; NODE_VERSION still 22.	2026-09-07 21:17:06 +02:00
joakimp	5972a2c535	test+docs: assert the node major in smoke, and correct v1.8.13's agent-browser version ... Two findings from a delegated read-only audit of this repo, both verified from the filesystem before patching. 1. No test asserted the node major, so a node-24 bump would have passed the smoke suite SILENTLY. scripts/smoke-test.sh:94 was a bare `run "node" "node --version"` — exit-0 and non-empty output only, the printed version compared to nothing — while the line above it uses run_expect against $EXPECTED_PI_VERSION for pi. A reader skimming the suite would reasonably assume node regressions were covered. Worse, this is where the "node v22.23.2 verified" line in the v1.8.13 recreate notes came from: printed output, not an assertion. Now gated on EXPECTED_NODE_MAJOR, which CI derives from Dockerfile.base's ARG NODE_VERSION — the single source of truth (Dockerfile.base:557 is the ONLY hard pin in the repo; Dockerfile.variant has no node install at all). That also catches a stale cached layer whose node disagrees with the declared ARG. Unset => previous behaviour, so this is backward compatible. Verified two-sided rather than assumed: the sed derivation yields 22 (empty would have silently disabled the assertion, reintroducing the bug); grep -Fq "v22." matches v22.23.2; "v24." does NOT match, so a wrong major is caught; and "v2." does not prefix-collide. Workflow YAML re-parsed after editing (9 jobs). 2. The v1.8.13 entry claimed "the image's own 0.35.2" for agent-browser. The image ships 0.36.0: /usr/lib/node_modules/agent-browser/package.json says version 0.36.0, engines.node >=24.0.0, and no 0.35.2 exists anywhere in the image. The claim was also internally incoherent, contrasting 0.36.0 against a version that is not present. Corrected in place with a visible note, since the entry is already released. The reasoning survives untouched: the engines floor really is vestigial, because /usr/bin/agent-browser is a prebuilt aarch64 ELF invoked directly and never through node — which is why 0.36.0 runs fine on 22.23.2.	2026-09-07 21:05:24 +02:00
joakimp	aa0fbc5ec0	fix: correct the pi-studio claim — CI publishes v0.9.59, not the v0.9.60-rc.0 label ... Measured at the wrong layer during the v1.8.13 audit. I read `ARG PI_STUDIO_REF=main` in Dockerfile.variant, concluded the release would adopt main (= v0.9.60-rc.0), set PI_STUDIO_VERSION to that, and wrote a comment plus a CHANGELOG entry describing deliberate RC adoption. A Dockerfile default cannot answer "what will CI publish?" when CI overrides it, and it does: build-variant passes PI_STUDIO_REF=studio_ref and PI_STUDIO_VERSION=studio_tag (lines 598-599 and 787-788), and resolve-versions picks the newest STABLE semver tag via `^v?[0-9]+\.[0-9]+\.[0-9]+$`, which excludes pre-releases. Caught by reading run 639's own resolve-versions output rather than the Dockerfile: studio_tag=v0.9.59, studio_ref=9eed84f = refs/tags/v0.9.59^{}, while main/v0.9.60-rc.0 is 658536f and never gets built. So published v1.8.13 studio images carry pi-studio v0.9.59. ARG restored to `none` rather than pinned to v0.9.59: the local-build default should not hardcode a tag that goes stale as soon as main moves, which is how the previous value came to lie. The comment now leads with the override so the next reader starts at the layer that decides. Upstream's tag-over-main policy is deliberate (Releases stopped at v0.5.55, main receives half-finished commits), so adopting an RC from CI would mean changing that filter, not this ARG. Consequence kept on purpose: the RC's opt-in Studio network binding is in NO published v1.8.13 image, so it needs no audit this release. Doc/label-only: base_tag hashes Dockerfile.base + rootfs/** + both entrypoints + mempalace_toolkit_ref, none of which this touches, so the in-flight base build (base-ad9faf00f2b2) stays valid and the tag run will reuse it. Verified with CI's pinned linters: hadolint 2.14.0 exit 0 on both Dockerfiles, actionlint 1.7.7 exit 0, shellcheck 0.10.0 -S error exit 0. v1.8.13	2026-09-06 23:51:00 +02:00
joakimp	702dd71f4c	ci: declare workflow_dispatch input types so Gitea renders the dispatch form ... Gitea (1.26.2) builds the "Run workflow" dialog from each input's `type:`. With no type declared, the form renders a branch selector and NO input fields, so a manual run silently takes every default -- and for release_tag: '' that means env.RELEASE_TAG resolves EMPTY, the variant tag list becomes `<image>:`, and the run dies on an invalid docker reference only AFTER paying the full base + smoke cost (~70 min). Net effect: the `smoke_only` escape hatch documented in this file's own header has been unreachable from the UI for its entire existence. Found 2026-09-06 while trying to use it to validate three new smoke assertions before cutting v1.8.13. Typed as `string`, deliberately, even though promote_latest/smoke_only read as booleans: all six consumption sites compare strings against 'true' (inputs.smoke_only != 'true' at both build-variant gates, inputs.promote_latest == 'true' at both promote gates) or interpolate into env.PROMOTE_LATEST. A boolean-typed input yields a real boolean, so `!= 'true'` would compare across types and could invert a publish gate silently rather than fail loudly. This keeps the change a pure rendering fix with zero semantic delta; switching to boolean would require re-auditing all six call sites. Validated locally with CI's own pinned tools before pushing, because lint is the only gate on this file: actionlint 1.7.7 exit 0 (clean baseline before the edit, clean after), shellcheck 0.10.0 -S error exit 0 across all 17 shell files, and a pyyaml structural check confirming the three inputs still carry string defaults, the `v*` tag trigger is intact, and all 9 jobs still parse.	2026-09-06 23:40:26 +02:00
joakimp	f561acc89a	skills: refresh vendored mempalace snapshot a12fe5e -> e9e09d9, re-pin the canary ... Folded into v1.8.13 at zero marginal cost: the snapshot is hashed into base_tag, but Dockerfile.base already changed this release, so the ~67 min base rebuild was already being paid. vendor-mempalace-skill.sh --check reported exit 0 (stale-but-truthful) beforehand, so skipping was sanctioned -- this is the deliberate call the release checklist asks for. Upstream content: the bare project-name wing convention and the <harness>@<device> added_by rule, both downstream of the attribution defect measured on this device 2026-09-06. The canary re-pin matters more than the refresh. Its old pair ("Provenance is stamped for you" present / "Attribute what you file yourself" absent) still PASSED against the new snapshot, so leaving it would have yielded a canary green on both old and new bytes -- blind to exactly the refresh it exists to witness, the same false-green family as the pre-v1.8.5 canary. New pair chosen by measuring direction against both files rather than reading the diff ("Diaries self-heal; plain drawers do not" new=1/old=0; "Agent diaries live in" new=0/old=1), then tested two-sided: PASS on refreshed bytes, FAIL on the old bytes recovered from git. Gates after the change: smoke-test.sh parses, vendor --check exit 0, check-base-hash exit 0.	2026-09-06 22:31:47 +02:00
joakimp	0d984b1414	changelog: cut v1.8.13 section	2026-09-06 22:14:20 +02:00
joakimp	adcf56f829	release: audited bumps (pi 0.85.1, mempalace 3.9.0, atelier v0.10.1) + two guards ... Version audit for the next release. pi 0.84.4 -> 0.85.1, deliberately skipping 0.85.0 (it published internal experimental code and broke SDK imports, upstream #9132). mempalace 3.8.0 -> 3.9.0. pi-atelier v0.10.0 -> v0.10.1. PI_STUDIO_VERSION relabelled none -> v0.9.60-rc.0 so the floating main ref's RC status is visible at docker-inspect time instead of discovered later. PI_FORK_REF stays floating and adopts e69725c. The pi bump was verified by running it under a pty in five combinations rather than by reading the changelog, because this repo has already shipped a version pair no changelog flagged (atelier < 0.7.1 hangs pi >= 0.84). CPU delta 0.00-0.01s over 5s against a ~5s sustained-CPU hang signature, two-sided via the atelier sidebar painting identically to the 0.84.4 control. NODE_VERSION stays 22 on purpose: node 24 is technically safe (pi's five prebuilt addons are all NAPI, nothing declares a ceiling, agent-browser's engines.node >=24 is vestigial for the shipped aarch64 ELF), but this release already moves two minors and bakes an RC, and a node major would leave four suspects if the image misbehaves. Own release, smoke suite as the gate. Also corrects a stale claim at the mempalace ARG: synlig serves 3.8.0 server-side, not 3.7.1 (measured over ssh 2026-09-06). agent-browser volume shadowing: the image has shipped 0.35.2, but every session on mbp-m1-2020 ran 0.27.0 from a 2026-07-17 hand-install in ~/.pi/npm-global (a VOLUME, at PATH position 2 vs /usr/bin at 8). Third package hit by this hazard after pi and pi-atelier, so the guard is now generalised: entrypoint-user.sh retires the copy by moving it aside (reversible, only when the image ships its own), recreate-sanity-check.sh asserts resolution under /usr where the volume is real, smoke-test.sh carries the build-time half and says in the source why it is weak. The real damage was the stale BUNDLED SKILL (3 skillsets/17.6 KB vs 8/31.5 KB, ten subcommands undocumented to the agent) - a stale tool errors, a stale skill quietly teaches wrong commands. pi-fork capability floor (extensions: []): forks were measured across four dispatches ignoring their brief, answering in the user's voice, fabricating self-referential measurements, and once filing a diary entry as agent_name=pi. Cause is upstream by design - the child gets getHeader()+getBranch(), the whole active session branch, with the brief as the final user message. Not a model-capability problem: the same model as the fast profile obeyed the identical brief perfectly with a fresh session and no inherited context. extensions: [] runs children with --no-extensions, so the mempalace bridge is absent and palace writes are impossible by construction (verified by asking a child to enumerate its tools: read, bash, edit, write). Removes palace writes, not filesystem writes.	2026-09-06 20:40:02 +02:00
joakimp	c8622ece9d	skills: correct the credential-incident-response §5 premise about chroma metadata ... §5 said embedding_metadata.string_value holds "metadata fields only". False, measured directly: chroma also stores a copy of the document text there, under key chroma:document. Confirmed with a disposable sentinel drawer (pi@tor-ms22, 2026-08-30): one row in fts_content AND one row in embedding_metadata for the same drawer. This was a real mistake in shipped guidance, not a nitpick: this section's own scanning advice was written to guard against explaining a zero with a mechanism nobody verified from source, and the section itself did exactly that -- I downgraded a census to "a floor" on the strength of a metadata-blind claim I never checked against chroma's actual storage layout. The practical scan order is unchanged (fts_content is still the direct target, raw bytes are still the backstop); only the stated REASON for a metadata zero changes: it needs a different explanation now (key filter, query shape, escaping), not "structurally absent". §6's row-gone/bytes-gone claim is upgraded from asserted to measured, same sentinel: delete_by_source took both fts_content and embedding_metadata 1->0, raw bytes stayed 4->4 (freed pages persist until VACUUM). Also records the method that unblocked the measurement: not a better instrument, a disposable sentinel drawer instead of risking real fleet data. No image behaviour changes.	2026-09-01 22:37:46 +02:00
joakimp	05843ecfae	changelog: reopen an Unreleased section after v1.8.12 ... v1.8.12's release retitled the previous Unreleased heading, leaving the file with no place to put the next change — so the next contributor either invents a heading or appends to a released section. The note under it points at the release checklist step that renames it, so the convention is discoverable from the file rather than only from AGENTS.md. Also the first push after moving CI off synlig: lint.yml should now run on runner-a1 (8 vCPU / 16 GB, Debian 13, upstream Docker CE) instead of the box that hosts the palace.	2026-09-01 00:29:29 +02:00
joakimp	a2846a5f7e	release: adopt pi 0.84.4 + pi-atelier v0.10.0, and fix the doc claim the pi bump invalidates ... pi 0.84.3 -> 0.84.4 (no Breaking Changes / Removed heading in that section, grepped). Adopted for three fixes that land on machinery this fleet runs: #6879 (large tool results crossing the auto-compaction threshold were sent to the provider before compacting), #8345 (a resumed session corrupted its next appended entry when the JSONL lacked a trailing newline -- that file is the memory feeder's input; measured 49/49 clean here beforehand), and #8537 (triggerTurn:false messages sent mid-run were inserted between a tool call and its result). The mempalace mailbox is outside #8537's precondition: it delivers at agent_settled with deliverAs:"steer" and no triggerTurn, and 0.84.4 leaves the documented steer semantics unchanged. pi-atelier v0.8.2 -> v0.10.0: two minor releases, both UI-only, no BREAKING notice. v0.9.0 raises its minimum pi to 0.84.0 and, unlike the 0.7.1-under-pi-0.84 startup-hang precedent, encodes it in peerDependencies (>=0.84.0). Satisfied by PI_VERSION=0.84.4. Both executable floors compare with sort -V, so 0.10.0 >= 0.7.1 evaluates correctly. docs/observational-memory.md: pi's own compaction.md gained one paragraph in 0.84.4 -- autoCompact is now also checked mid-run, after a tool batch's results are appended. Our text said compaction is checked only when pi goes idle and so "never interrupts a turn"; that was only ever true of the OM trigger. The section now states both entry points into session_before_compact and the diagram carries the second edge (mermaid checker re-run: 6 blocks, 44 labels, 0 soft-wrapped, no cut glyphs at 1280px and 800px). README: the version-pin table had been wrong since v1.8.6 -- 93f986e moved ARG PI_VERSION to 0.84.3 and MEMPALACE_VERSION to 3.8.0 and neither table row, so it advertised pi 0.84.2 / mempalace 3.7.1. Corrected, plus the --expected-version example that would now fail against a 0.84.4 image. CHANGELOG: Unreleased retitled v1.8.12 (2026-08-31) with the audits above and a dependency-audit table -- every other component measured SAME (skillset snapshot --check OK at a12fe5e, 0 commits since baked). v1.8.12	2026-08-31 07:08:41 +02:00
joakimp	58c22afb04	skills: the fingerprint advice was missing its precondition, and the skill had no section on proving absence ... Docs only; no image behaviour changes. WHY THIS AND NOT A PRIVATE NOTE. pi@emb-7kj4vr4g reported itself for printing sha256[:8] fingerprints of GIT_USER_EMAIL, GIT_USER_NAME and HOST_SSH_USER, and wrote a private rule forbidding it. It had not broken a rule. It followed §2 of this skill as written, and §2 is incomplete: it says a fingerprint lets you compare a credential "without ever materialising the secret" with no condition attached. When two agents independently make the same mistake, the artifact that taught them both is the bug. §2 NOW CARRIES THE PRECONDITION. A fingerprint is 32 bits over its INPUT SPACE, so publishing fp8(x) hands anyone a MEMBERSHIP ORACLE: they can test x == v for every candidate v they can generate. Safe for a 40-char random token; a wordlist for a hostname, username, e-mail, port, path, commit SHA or weak password. "High entropy" is the usual sufficient condition, NOT the test — a commit SHA is 160-bit and still fully enumerable from the repo. Operationally: if you can imagine writing the wordlist, you cannot publish the fingerprint. Also added: candidate fingerprints are working memory and never output (an extractor hashes hostnames and paths too, so the tempting "print what the scanner saw" debug step leaks low-entropy fingerprints wholesale), and a plain statement that a fingerprint register is a CONFIRMATION ORACLE for anyone already holding a candidate corpus — which is exactly how a retired token is identified in old transcripts, and works identically for someone else holding those same files. NEW §6, "Proving absence: instrument strength, and four ways a scan lies clean", placed next to §5 on purpose: §5 optimises against false POSITIVES, and every failure in §6 is a false NEGATIVE. Triage optimises precision, a gate optimises recall, and conflating them is what produced three clean reports over secrets that were really there. Contents: instrument ranking (exact-byte value search > class/structure pass > fingerprint census) with the instruction to state which one produced your zero; census vs class passes as different questions, both failure modes measured on this fleet; the tokenisation trap where quoting alone decided detectability; scan the index or pushed tree, never the working tree; git filters never run on symlinks while check-attr claims they do; two-sided self-tests that abort, incl. the fixture-interaction artifact; row-gone is not bytes-gone. Attribution kept per finding: the census/class split and the instrument ranking's provenance are pi@emb-7kj4vr4g's; exact-byte search over index blobs is pi@tor-ms22's. The credential sense of "census" originated in this skill, not with either agent. TRAP FOR THE NEXT EDITOR, also in the CHANGELOG: the frontmatter description is now 1022 of 1024 characters. Trim before adding, or the skill silently fails to load. Verified by parsing the frontmatter (1022 chars, name intact, every prior trigger phrase retained). Deployment: baked skill -> needs an image rebuild AND a container recreate to reach a running container.	2026-08-30 23:32:53 +02:00
joakimp	30094782df	shell: source cli_utils' functions, and install the iproute2 that one of them needs ... v1.8.11 linked cli_utils' bin/ COMMANDS onto PATH and stopped there. Nothing ever sourced cli_utils.sh, so its 14 FUNCTIONS were missing from every interactive shell whose $HOME has no zsh rc -- which is the normal case, not an edge case: the container's interactive shell is bash and zsh is not installed in the image. A symlink cannot carry a shell function and a function cannot be reached from a non-interactive shell, so the two mechanisms are disjoint and both are required. The image was already paying this layer's dependency cost (fzf, bat, fd, rg, jq are baked partly FOR these functions) while delivering none of its benefit. The two changes ship together because they are coupled: portcheck is one of the 14, and it was a hard stub in every image up to v1.8.11 -- neither ss nor ip nor lsof nor netstat was present, so it printed "portcheck requires at least one of: ss, lsof, netstat" and exited. Wiring the functions in without iproute2 would have shipped a visibly broken one. MEASURED, not assumed: - the loader is bash-safe despite the *.zsh filenames: `bash --noprofile --norc` exits 0, defines all 14, and they run (pathls, mkcd, up, extract, agents-sync, fhist verified). The tree's one zsh-only construct (print -z in fzf/fhist.zsh) is already guarded by [[ -n $ZSH_VERSION ]] with a bash fallback. - fresh-$HOME seeding resolves 14/14; CLI_UTILS_SOURCE=0 is honoured; an absent checkout is a genuinely silent no-op (no output, no leaked _cu). - interactive shell startup 12 ms -> 17 ms. - iproute2 is ~5.5 MB (4.2 MB itself + 6 libs under --no-install-recommends; libpam-cap is a Recommends and correctly dropped). ss lands at /usr/bin/ss, ip at /usr/sbin/ip, both already on the developer PATH, and `portcheck --all` then correctly identifies the socat listener on 8765. - hadolint clean on both Dockerfiles; repo-wide shellcheck -S error and bash -n clean. .bash_aliases is outside CI's discovery (no shebang, not *.sh), so it was checked by hand with -s bash at error AND warning level. Named explicitly per this repo's floating-ref rule: /workspace/cli_utils is a HOST BIND MOUNT, not a pinned ref, so the image now executes unpinned content in every interactive shell. Errors are left visible rather than sent to /dev/null so that a future zsh-only file in that repo is diagnosable rather than mysterious, and CLI_UTILS_SOURCE=0 is the documented escape hatch. It is deliberately independent of CLI_UTILS_LINK=0: the two disable independent mechanisms. Deployment: needs a rebuild AND a recreate. $HOME is the container's writable layer rather than a named volume (verified -- ~/.bash_aliases carries the container start mtime while ~/.bashrc carries the image's), so the skel file is re-seeded on every recreate; a host-bind-mounted ~/.bash_aliases is still never overwritten.	2026-08-30 11:48:03 +02:00
joakimp	9b5783f9dd	skills: a sixth instance, found by the repo owner within the hour ... Claimed "## Unreleased is a new convention in this repo" after reading CHANGELOG.md once — minutes after b615571 had renamed that very section to `## v1.8.11`. 33 commits touch the heading; the convention is that new entries land under Unreleased and the heading is renamed at tag time, exactly as it was renamed out from under my snapshot. Same root cause as the five instances the section above already records: an absence observed in one frame, promoted to a fact about the world, with no second measurement. `git log -S'## Unreleased' -- CHANGELOG.md` was the oracle and costs one command. The generalisation is worth more than the instance, so it goes in the habits block: to learn a repeating PROCESS, read history, not the file. A file's current content is one frame of a cycle, and the frame you catch may be the one where the thing you are looking for has just been consumed.	2026-08-30 10:50:20 +02:00
joakimp	d9a7fe101b	changelog: an Unreleased section for a rule that was already there ... Records the two skill commits ahead of tomorrow's build, and states the finding that shaped them: the "a negative result is usually your own filter" rule was already baked, already symlinked in at every container start, and already survived every recreate — then was violated five times by a session that had it available. The gap was activation, not persistence, which is why the cross-cutting form went into the always-appended AGENTS block instead of into a skill that only loads when a task description matches. Also notes what the entry's own subject implies for the reader: neither change reaches a running container until the image is rebuilt AND the container recreated, since ~/.agents/skills and the global AGENTS.md both live in the image rather than in a volume or a mount.	2026-08-30 00:52:36 +02:00
joakimp	36e65fe657	skills: add credential-incident-response, and assert it stays baked ... Carries the facts a two-day credential incident produced, not the discipline: probe the issuer FIRST (11 of 13 "exposed" credentials were already dead at the provider, which cost five HTTP requests to learn and was never checked), the 403-vs-401 trap that scoped tokens introduce into liveness probes, revocation beats deletion for anything already replicated, the three places a secret hides in a Chroma palace (FTS content, metadata, raw bytes) in coverage order, scope derivation from measured consumers, and this fleet's age store with its single-recipient weakness. Facts transfer between sessions; exhortations do not — hence a separate skill for the domain knowledge and a one-line pointer in the always-loaded block. Authored here, so baked is canonical and it is NOT added to skillset-owned.txt. Skill dirs are picked up by a glob in entrypoint-user.sh, so no registration is needed — verified rather than assumed, since an enumerated list would have left the skill inert, a fitting failure given its subject. Three smoke assertions extended so a future rebuild cannot silently drop it.	2026-08-30 00:50:11 +02:00
joakimp	f0ebea2d98	skills: fix the half of the negative-result rule that was wrong ... pi-devbox-environment already warned that "a negative result is usually your own filter" — baked, symlinked in at every container start, authored by an earlier session. It survived every recreate, was available all of a later session, and was violated five times anyway. So the gap was never persistence. That section also closed with "a positive result needs no such scepticism — it carries its own evidence." That is false, and it aimed the scepticism budget one way only. Three of those five errors were positives: - an SSH handshake SUCCEEDED and greeted me as joakimp while I believed I was probing gitea.egl.lan — `Host gitea*` had rewritten HostName - a 401 that was a genuine answer from an issuer which never minted the token - a "regression" produced by diffing against a value my own -p 2222 flag set Adds the three missing false-negative rows, replaces the false claim with the "a positive result only proves what you actually asked" subsection, and records the two habits that actually caught these: `ssh -G` to learn which rule captured a hostname, and declaring the expected result before running a check. The cross-cutting form goes in pi-global-AGENTS.append.md rather than in a skill, because it has to fire without a task description matching it — being loadable on demand is exactly what failed. Across all five errors, none was caught by re-reading my reasoning; every one was caught by a second measurement that disagreed.	2026-08-30 00:50:11 +02:00
joakimp	b615571913	changelog: release v1.8.11 — the mail nobody could deliver, and the ship that skipped a file ... Names three things riding in via floating refs, since the rule this fleet adopted (v1.8.9) is to name a behaviour change before tagging, not after: - mempalace-toolkit b2b50af -> 21023e7: the rsync --checksum ship fix (a real behaviour change to every remote-mode client) and RFC 003 §7.13 (docs only). - skillset 6eb20af -> a12fe5e: mermaid-diagrams cutU normalisation and the mempalace skill's from_agent identity rule, plus the vendored fallback snapshot re-pinned to match (this pi-devbox commit). Dependency audit run by direct command against every component, not assumed: pi/mempalace/pi-atelier/pi-studio/pi-toolkit/pi-extensions/ pi-fork/pi-observational-memory all confirmed unchanged since v1.8.10. pi-studio's apparent SHA drift on ls-remote turned out to be an annotated-tag-object hash vs its underlying commit hash, not real drift -- checked with ^{commit} before writing it down as 'none'. v1.8.11	2026-08-27 23:39:39 +02:00
joakimp	495b7e3859	vendor: resync mempalace skill snapshot to skillset a12fe5e ... scripts/vendor-mempalace-skill.sh, real refresh not --check: skillset moved 6eb20af -> a12fe5e (mermaid-diagrams cutU normalisation, and the from_agent identity rule this same release ships in RFC 003). --check reported stale-but-truthful (exit 0, the sanctioned skip) but this release's point is getting today's fixes live fleet-wide, and the base rebuild is already forced by the entrypoint change and the floating mempalace-toolkit ref moving -- so the incremental cost of also bumping this pin is zero. Phrase canary in scripts/smoke-test.sh unaffected: neither pinned phrase ('Provenance is stamped for you' present, 'Attribute what you file yourself' absent) is in the section that changed; both verified still correct in the new snapshot.	2026-08-27 23:36:03 +02:00
joakimp	45850bc973	entrypoint: put back the shell state a recreate eats ... cli_utils' install.sh reaches PATH by symlinking bin/ into ~/.local/bin. That is persistent on a host and ephemeral in a container, so the same installer produced opposite durability and every --force-recreate sent the human back to typing /workspace/cli_utils/bin/git-status-all. Re-link at start instead, and add a per-device boot hook so the next question of this shape needs no image change at all. Symlinks rather than a PATH edit in an rc file, deliberately: ~/.local/bin is already ahead of /usr/local/bin in ENV PATH, so links resolve in NON-interactive shells too (docker exec, agent tool shells, scripts). An rc-file PATH edit cannot reach those because ~/.bashrc returns early when not interactive — measured, that asymmetry is exactly why `command -v git-status-all` failed in one shell and worked in another on the same box. Shell FUNCTIONS remain the sourced file's job; a symlink cannot carry them. Guards, because ~/.local/bin is shared: a real file is never clobbered, a symlink pointing elsewhere is never stolen, ours are refreshed, and links into a cli_utils/bin whose target vanished are pruned — a dangling link on PATH reads as a broken container rather than a removed script. The hook (~/.config/devbox-shell/init.sh) adds no trust boundary: that dir is already sourced into every interactive shell by the baked bash_aliases, so it is already arbitrary code from the same owner. Only WHEN it runs is new. bash <file>, never sourced, exit status ignored, output to a log. Caught before commit, and the reason the loops use `if` bodies instead of `&&` chains: under `set -euo pipefail` a for-loop whose last command is a false test exits non-zero, and with no match the /workspace/*/cli_utils glob stays literal — so the first draft would have failed to START a container on every machine that does not have this repo, rather than merely skipping the links. Re-tested with set -e in place: no-cli_utils/empty-HOME no-op, guards, idempotence, CLI_UTILS_LINK=0, a hook that exits 7, and a hook that tries to mutate CLI_UTILS_BIN — all exit 0 with intact state. Not covered by CI: docker-publish.yml runs only on tags and lint.yml lints workflow run: steps, so neither executes this file. Validated by extracting both sections and running them against fixtures, then for real in a live v1.8.10 container. No smoke assertion added on purpose — the positive path needs a /workspace mount smoke does not have, and asserting it there would repeat the v1.8.0 mistake of a smoke check written against a stage that does not exist at run time. Moves the base hash (base-decide folds `cat entrypoint.sh entrypoint-user.sh`), so this rides along with the next tag's ~40-minute base rebuild rather than justifying a tag of its own.	2026-08-27 21:52:51 +02:00
joakimp	6891dc32b8	changelog: release v1.8.10 — deploy the scrubber, and name the check that must not be skipped ... Audited every component against upstream rather than assuming. Only two moved since v1.8.9: - mempalace-toolkit 5b8d78f -> b2b50af (ours): feeder scrubber, the symlink fix that stops it refusing to stage, hlc owed-set join, queued-delivery note, explicit MEMPALACE_MAILBOX_NOTIFY protocol modes, RFC 003 + fleet-memory docs. - pi-studio v0.9.48 -> v0.9.52 (upstream, studio variant only): 22 commits, all additive — PDF previews, hideable header, contextual side questions. No removals or renames. Its pi floor is >=0.84.3 against our exact 0.84.3 pin: satisfied, zero headroom, named as a watch item because the next floor bump breaks the studio job only, after core has already published. Verified unchanged, with dates proving they predate the v1.8.9 bake: pi 0.84.3 (= npm latest), mempalace 3.8.0 (= PyPI latest), pi-atelier v0.8.2, playwright 1.62.1 (no drift this cycle despite floating on latest), pi-fork bf702b4, pi-obsmem ce9fc98, pi-toolkit 0e1369e, pi-extensions 2022887. No breaking changes anywhere, so everything can ship in one tag. The reason for tagging now is not features. The scrubber has been live on exactly ONE device since this morning; every other device has kept staging unscrubbed transcripts into a shared palace, and cleanup after the fact is manual redaction (done twice today, with freed-page residue left behind by choice). The entry leads with the acceptance check instead of burying it, because this release's worst failure is silent: the feeder is fail-closed, so a packaging or path mistake stops the fleet's memory feed and nothing complains — refusing to stage looks exactly like a quiet session. f0bffd1 exists because that very bug was real (BASH_SOURCE reports the symlink path, not the target). First client on the new image must confirm a [scrub] summary line appears, the drawer count moves, and exit 3 did not fire. Silence is the failure signal, not success. v1.8.10	2026-08-27 17:51:46 +02:00
Joakim Persson	8a673ec143	docs: unclip the diagrams, and answer what compaction leaves behind ... Two problems reported against docs/observational-memory.md, one cosmetic and one substantive. Both turned out to be worth more than the fix. Clipping. Several boxes lost their bottom line of text in the viewer, and neither the source nor my own render showed it. Cause: Mermaid measures a node label with its own font metrics, commits to a box size, then renders that label as real HTML in a <foreignObject> — so any host stylesheet touching line-height or font-size inflates the text past a box that is already fixed, and the overflow is clipped. The error accumulates per line, which is why it always eats the last line of the tallest labels. Rejected the obvious fix after testing it rather than assuming it: %%{init: {'flowchart': {'htmlLabels': false}}}%% *is* honoured (labels switch from 16 foreignObject to 7 tspan) and clips identically, because inflated font-size inherits into SVG text too. The fix that works is a hard limit of two short lines per node, with the detail moved into prose under each diagram — one- and two-line boxes have the vertical slack to absorb inflation, three- and four-line boxes do not. The nodes were carrying paragraph-sized text; the diagrams are better for losing it. Regression harness: render every block with line-height: 1.7 !important forced onto the label HTML, screenshot, read it. That caught two survivors of the rewrite that looked fine in the clean render — a long unbreakable /opt path wrapping to a third line, and a cylinder shape whose curved bottom leaves less room than a rectangle for the same two lines. New §4, because the document explained that compaction folds the ledger and never said what that leaves in the context. Asked directly: is the session back to knowing nothing? No. A verbatim tail survives, sized by keepRecentTokens (20k) and cut only at turn boundaries; the system prompt and AGENTS.md were never in the compacted region because they are rebuilt from disk each request; nothing is deleted from disk, since compaction appends a compaction entry rather than rewriting lines; and recall keeps resolving ids whose sources left the context because it reads the full branch via sessionManager.getBranch() and never consults the context window. Repeated compaction renders from live records, not from the previous summary's prose, so there is no generation-loss spiral. Also corrects this repo's own "compaction calls no model" to the steady-state claim it actually is: with an empty ledger the hook returns nothing and explicitly declines ownership, and pi's native model-based summariser runs. Snippet quoted in the doc. And a bug shipped in the first version: §9 said the ledger entries are custom_message and specifically not custom. Exactly backwards, so the one grep that section existed to get right was the one it got wrong. Verified empirically against the live session file — 11 om.observations.recorded and 6 om.reflections.recorded, all "type":"custom", next to "type":"custom_message" entries whose customType is mempalace-mailbox and mempalace-wakeup. That is where the confusion came from, and the distinction is load-bearing rather than cosmetic: the mailbox uses the context-visible append API, om's ledger uses the invisible one. Which makes it a feature the doc now advertises — the ledger costs zero context until it is folded.	2026-08-27 14:24:19 +02:00
joakimp	cdb6fc0950	changelog: name what the floating toolkit ref will pull into the next tag ... MEMPALACE_TOOLKIT_REF=main floats and docker-publish.yml resolves it to a SHA at build time, so toolkit main moving 5b8d78f -> f0bffd1 (10 commits) ships in the next tagged image whether or not this repo has a commit. v1.8.9 adopted the rule after that shape bit twice (553d865, 5b8d78f): name the behaviour change BEFORE tagging. This is that rule obeyed rather than re-learned — the work was pushed to toolkit main earlier today and this entry was missing, which is exactly the gap that caused a cross-host misattribution in v1.8.7. Contents: the feeder-side secret scrubber (three tiers, T3 report-only after a measured 403 -> 29 false-positive calibration on 52 MB of real transcripts, fail closed); the symlink near-miss that fail-closed would have turned into a fleet-wide silent memory outage at bake time, caught before tagging; the mailbox work (hlc owed-set join, queued-until-next-turn note, explicit notify protocol modes, tmux path documented unverified); and the documentation set (RFC 003, fleet-memory.md, secret-hygiene.md). Also states what remains unscrubbed: the opencode bridge write path and the unbuilt server-side layer. No tag pushed — per the release protocol, no tag means no build.	2026-08-27 14:20:35 +02:00
Joakim Persson	14371e2da6	docs: explain the memory that runs itself, and fix a claim the mailbox falsified ... `pi-observational-memory` is baked, registered in the seeded settings.json, and handed a cheaper model than the session it serves — and the only description in this repo was five words in a feature list. Someone meeting `/om:status` or a "compacted memory" block had nothing to read that said whether to leave any of it on. New docs/observational-memory.md, 272 lines and five diagrams. Scoped by who is authoritative, so there is one copy of each claim: - Upstream (/opt/pi-observational-memory/docs/) already documents the mechanism well — concepts.md, how-it-works.md, configuration.md, including a v3 lifecycle diagram that matches the deployed code. Linked, not re-derived. - This document takes the four facts pi-devbox owns and can change: the pinned commit it bakes (v3.0.4 ce9fc98, matching build-manifest.json), the packages[] entry that decides which copy loads, the Haiku-workers-vs-Opus-session split, and the devbox-pi-config volume that makes the ledger outlive the container. - Plus the confusion this image creates by shipping two things called memory: a section contrasting it with MemPalace, on the line "observational memory keeps a session coherent, the palace keeps the fleet coherent". Placement follows the split fleet-ops states for itself — reusable mechanism is not deployment data — so a "why is this in my container" document belongs in the repo that pins and wires the component. Linked twice from the README, because until this commit the README referenced docs/ zero times and the file already sitting there was reachable only by listing the directory. Numbers were read out of the live container and the baked tree rather than out of release notes, which caught one thing the pi-extensions skill still has wrong: the dropper is gated on a successful same-turn reflection, not on a token threshold of its own. Also fixes a README sentence that v1.8.9 made false. § Cross-machine agent coordination ended with "Nothing in this image polls the log on the agent's behalf"; the mailbox has shipped since aac4a1c. Replaced with the three knobs and their defaults, derived-not-read owed-ness, and the queued-into-the-next-turn delivery measured on two devices — and dated to "as baked in v1.8.9 (mempalace-toolkit 5b8d78f)", pointing at RFC 003 §7.11–§7.12 for the mechanism, because toolkit main is already ahead (a92c75d pings the human who is not looking) and describing that here would trade a stale-behind claim for a stale-ahead one. The cause is worth more than the fix: the behaviour arrived through the floating MEMPALACE_TOOLKIT_REF, so no diff in this repo ever touched the paragraph making the claim. v1.8.9's own rule fired for the CHANGELOG and nobody swept the README. The CHANGELOG records what changed, the README asserts what is true, and only the first is reviewed at release time — so the rule now extends to grepping the README for absolute claims (nothing, never, does not, only) about a component whose SHA moved. Diagrams were verified by rendering, not by parsing. Both comparison diagrams parsed clean and rendered with their meaning reversed: Mermaid laid the second declared subgraph out first, putting "with observational memory" before "without" and MemPalace before observational memory in the diagram whose entire job was that contrast. Rebuilt as declaration-ordered chains and re-rendered at mermaid@11 — the version pi-studio pins — in the baked headless browser, then read back as an image. mermaid.parse() proves syntax and says nothing about layout.	2026-08-27 13:55:55 +02:00
joakimp	aac4a1c323	release: v1.8.9 — the version flag that blamed the wrong component ... Two versions, two flags. `--expected-version` has only ever asserted `pi --version`, but AGENTS.md step 4 spelled it `X.Y.Z` inside a checklist where every other X.Y.Z is the pi-devbox tag. Run as documented for v1.8.8 the final runtime gate of the release printed ✗ pi version mismatch: expected 1.8.8, got 0.84.3 and exited 1 — a red accusing the image of being the wrong version. Not one reader's slip: the v1.8.8 release-readiness handoff from pi@emb-7kj4vr4g propagated the same wrong spelling twice while correctly calling step 4 "not ceremonial", so two independent readers converged on it. README.md had it right all along, which means the two documents disagreed. - new --expected-image-version asserts the pi-devbox release tag, read from release_tag in /etc/pi-devbox/build-manifest.json (no checkout, no network); leading `v` optional on either side - both flags detect being handed the other one's value, and the test is exact rather than heuristic: the value is compared against the other quantity the image itself reports, so it can only fire on a real mix-up - neither flag is required now. With none, live `pi --version` is asserted against the manifest's pi_version — not a tautology, since a stale pi in the ~/.pi/npm-global volume can shadow the baked one, exactly as a stale npm:pi-atelier can in packages[] - the header note replaced was stale and load-bearing: it claimed pi is resolved from 'latest' and cannot be self-derived, while Dockerfile.variant pins ARG PI_VERSION=0.84.3 and docker-publish.yml reads that ARG as its source of truth. The same withdrawn claim also sat in cli_utils' pi-devbox-sanity --help - argument parsing: a missing value, or a value that is another flag, is a usage error instead of silently consuming the next argument; --help works All fourteen flag combinations exercised by execution, including the two manifest-absent branches and the shadowing branch a healthy container cannot reach — mutation-tested with a doctored manifest so each failure branch was observed firing rather than assumed present. CHANGELOG also names what no commit here causes: mempalace-toolkit main moved e70bef2 -> 5b8d78f, so this tag ships the auto-delivered logstream mailbox because base_tag folds the resolved toolkit SHA. It would have landed either way; going unnamed is the 553d865 shape that already caused one cross-host misattribution. Component audit found nothing else to bump — pi, mempalace, pi-atelier all equal their upstream latest, and every other floating ref resolves to the commit already baked. v1.8.9	2026-08-26 18:47:03 +02:00
joakimp	34cf1e3810	release: v1.8.8, and a notice that named the wrong remedy ... Freezes the v1.8.8 section and clears the two non-code checklist items pi@emb-7kj4vr4g handed over (evt_20260826T134919_a614ecfc2d4f), plus the two carried nits from its round-2 verification (evt_20260826T133356_d56792791a49). Every claim below was re-measured here rather than taken from the handoff. THE STALENESS NOTICE ASSERTED A DIRECTION IT NEVER TESTED — Blocker 1's shape, one layer down, in the message I added to replace the message that named the wrong cause. The notice fired on "recorded != HEAD" and then announced HEAD as the newer side without testing ancestry, so a clone that was merely BEHIND got "has moved to 82a8d3c; the snapshot describes the older 5fd0d5c" when 82a8d3c is 5fd0d5c's ANCESTOR. Found by EMB against the real state of its own host, not a fabrication. The verdict was never wrong (rc 0, nothing mis-verified) but the remedy it implies is a ~67-minute base rebuild when the actual fix is `git pull` — the only one of the two carried nits with a price tag, which is why it went first. Now tests ancestry with the merge-base --is-ancestor primitive the refresh path 60 lines below already used, and reports three verdicts: stale (refresh), clone behind (pull, do NOT refresh), diverged (reconcile). All three verified by execution; only the first was correct before. --help no longer errors on the one script whose argument order was itself a landmine. The `-s "$VENDORED"` guard is now commented as load-bearing: it makes the empty-stdin collision unreachable by construction, which also means no test below exercises it any more, so deleting it as "redundant with the probes" would silently restore the false OK. CHANGELOG: retitled, and three stale spots fixed in what becomes the permanent record. It cited the skill at 82a8d3c (twice superseded); it RE-ASSERTED the retracted mailbox measurement as live evidence 200 lines after withdrawing it, which is the exact non-contradiction failure this release exists to fix; and its warning block still described the pre-e8ddeaf world ("still records c04cd15", "now exits 1") while quoting as exemplary the very notice whose direction was unverified. Per EMB's steer the conclusion was kept and only the evidence replaced: the status filter does drop broadcast noise, it just never computed owed-ness. Honest replacement, measured on both machines: raw filter returns 2 here and 1 there, EVERY ONE already answered, derivation returns 0 for both. SNAPSHOT RESYNCED AGAIN, 5fd0d5c -> 6eb20af, because skillset 6eb20af adds the limit of my own seq ordering test: seq is REPLICA-LOCAL, equal to origin_seq only because one replica authors for all four machines, so use hlc once mesh_peers reports a peer. Recorded as reasoning not measurement — a second replica cannot be stood up here. The durable half is the asymmetry: seq skew makes an ANSWERED item resurface (noise, visible, self-correcting) while created_at SUPPRESSES AN UNANSWERED ask forever (silent, permanent), so the skill now says outright that "fixing" a resurfacing item with a timestamp trades the safe failure for the dangerous one. The resync was free: rootfs/ was already changing, so the base rebuild was forced regardless — the ordering warning about accidental staleness does not apply to a deliberate refresh before the tag. --check is a clean OK at 6eb20af with no notice, canary re-verified bidirectionally (present 3, withdrawn 0), baked snapshot 0644, tree hash recomputed at build time and re-verified in-container. bash -n clean; shellcheck/hadolint/actionlint remain absent locally, so CI is still the only evidence for those. v1.8.8	2026-08-26 15:56:03 +02:00
joakimp	e8ddeaf89f	skills: a gate that could pass without checking, and a mailbox that never empties ... Fixes the three blockers and seven should-fixes from pi@emb-7kj4vr4g's review (logstream correlation skills-provenance-review, full text in drawer_pi-devbox_reviews_e43e766641c9ec85217bc6ce). Every finding was reproduced by execution here before being fixed; two were refined by that reproduction rather than taken as given. BLOCKER 1 — the provenance gate could print OK and exit 0 without verifying. `git show <ref>:<path> | sha256sum` hashes EMPTY STDIN when the ref does not resolve, so at_ref was never empty and the UNKNOWN branch was dead code. Measured: a bogus ref reported MISMATCH — accusing the snapshot of lying when the real cause was an incomplete clone, and the operator's natural remedy for MISMATCH is to re-run the refresh, which rewrites provenance to silence the complaint; and with a 0-byte snapshot against a 0-byte upstream file it printed "OK: exactly skillset@aaaaaaa" with exit 0 for a ref that does not exist. The script already had the sha_empty idiom and had applied it to blob_sha but not to at_ref. Existence is now PROVEN with git cat-file -e before anything is hashed, at two levels (ref resolves / path exists at it) because those deserve different messages. Same defect class as the canary it replaces: a check that can succeed without checking. A second, unflagged instance of the same pipeline shape in blob_sha was found and fixed too. Exit codes split, because the old contract failed the sanctioned case: 0 truthful (including stale, with a NOTICE), 1 a lying record only, 2 cannot determine. AGENTS.md step 2 promised "the message distinguishes the two" and was the thing this branch was breaking; rewritten to state all three. BLOCKER 3 — VENDORED.md contradicted itself in the release whose stated invariant is non-contradiction: its hand-maintained provenance line named skillset 670f7f1, seven commits behind the ARG and itself the commit that told agents to hand-stamp added_by — the withdrawn instruction this work exists to stop shipping — while its cp recipe contradicted the "not cp" rule 20 lines above. Line removed (nothing forced it to move when the ARGs did); 670f7f1 kept only as a labelled cautionary example. The pi-extensions half was verified redundant (CI require_sha resolves PI_EXTENSIONS_REF) before removal. SHOULD-FIXES: `<root> --check`, the spelling VENDORED.md documented, silently ran a REFRESH because only $1 was parsed (both tools now parse all args and reject unknown ones); refresh at a detached/older HEAD silently rewound ref and bytes (now refused unless the recorded ref is an ancestor, --force to override); upstream_dirty was computed and never used in check mode; --no-skills --json printed human text and broke jq; --help was a hardcoded sed range this branch had already made stale; the fingerprint hashed SKILL.md alone so a live skill differing only in a sibling file reported "identical", and pi-extensions already ships two files, so it is now a per-skill TREE hash with the manifest field renamed skillset_snapshot_tree_sha256; the --no-skills smoke assertion was negative-only and passed on a crashed binary. mktemp+mv left files 0600 — CI was unaffected since the index records 100644, so the blast radius was local builds only, narrower than the review inferred. Snapshot resynced c04cd15 -> 5fd0d5c so the no-clone fallback carries the CORRECTED coordination protocol rather than the withdrawn one; --check is now OK with no staleness notice, and the bidirectional canary re-verified against the new bytes. Local validation is bash -n only (shellcheck, hadolint and actionlint are all absent in this container) — CI remains the shellcheck gate.	2026-08-26 14:38:07 +02:00
joakimp	49a6534093	docs: write down the coordination channel the fleet already runs on ... The logstream has carried cross-machine work since 2026-08-18 — patch handoff, review, a v1->v2 supersede — and nothing in this repo said it existed. That gap had a measurable cost this morning: another host addressed a retraction to pi@tor-ms22 by name and it was read only because the human said "read the logstream", while the agent was actively rebuilding the thing it warned about. Split by what each document is authoritative for, so there is one copy of each claim rather than three that drift: - README § Cross-machine agent coordination — what the CONTAINER needs. MEMPALACE_REMOTE_URL selects the shared palace; MEMPALACE_PI_DEVICE is what makes this machine reachable, because where every host is a thin client of one palace the stamped agent name is the only thing that distinguishes them. Stated as a rule with teeth: set both or neither, since a container missing the device var can read the log but is addressable by nobody. - AGENTS.md release checklist step 2 — the vendored-snapshot refresh, as a MECHANISM in the document a releasing agent actually reads, not a comment hoping to be noticed. It says the refresh costs a base rebuild, that skipping it is legitimate (every enrolled host reads its live clone), and that skipping it silently is not. - CHANGELOG — the three-way split itself, plus the measurement that shaped the ack contract: unfiltered, the mailbox returned 5 events, 4 of them finished broadcasts from eight days earlier; with status="open", exactly the 1 that needed an answer. Norms live in the skillset skill (82a8d3c, already live on every host that mounts the skillset — no rebuild) and mechanism in mempalace-toolkit's extensions/pi/README.md (e70bef2, which also documents the edge stamper that 553d8657 shipped undocumented). Deliberately NOT duplicated here. Consequence recorded rather than hidden: the skill edit lands in the skillset, so this repo's SKILLSET_SNAPSHOT_REF now honestly reports itself behind, and --check exits 1 with "has moved to 82a8d3c; the snapshot describes the older c04cd15". That message is also fixed in this commit — it previously blamed "the working tree" even when the tree was clean and only the ref had moved, which is the same defect class as a canary pinned to a phrase the release deleted: a message that names the wrong cause. Now distinguishes moved-HEAD from dirty-tree, verified against both plus the in-sync case.	2026-08-26 12:51:26 +02:00
joakimp	e070e0bcbf	skills: record the vendored snapshot's provenance, and report which copy wins ... Found while verifying v1.8.7 from inside a fresh container: the baked mempalace snapshot is read by no host on this fleet. devbox-skill-reconcile repoints ~/.agents/skills/mempalace at the mounted live clone (the v1.8.5 fix working as designed), and all four compose stacks mount a workspace containing the skillset. So the phrase canary that blocked v1.8.7's first tag polices a file nobody opens, while the drift that could actually mislead an agent — a git pull nobody ran in /workspace/skillset — was invisible from inside the container and is invisible to CI by construction. Record provenance instead of policing it, and move the check to where the skillset actually is: - Dockerfile.variant: ARG SKILLSET_SNAPSHOT_REF (the claim) + a sha256 of the shipped bytes measured in the manifest layer (the fact), as manifest siblings rather than components{} members, plus an OCI label. An ARG default, not a CI-resolved output: no credential for the private skillset, no change at any of the four variant build call sites, and a local docker build records what CI does. Variant-only, so no base rebuild — check-base-hash.sh scans Dockerfile.base alone, verified by running it. - pi-devbox-version: a skills: section naming baked vs live <repo> @ <sha> per vendored skill, and for mempalace whether the live copy is identical to the baked fingerprint, at the same commit with uncommitted edits, or divergent. entrypoint-user.sh passes the new --no-skills, because the banner prints before the links exist and long before the reconcile runs. - scripts/vendor-mempalace-skill.sh: refresh the file and rewrite the ref together (a cp without an ARG bump makes the manifest lie, which is worse than anonymity); --check verifies the claim against a real clone. - 5 new smoke assertions (78 -> 83), mutation-tested through the real sh -c path: 6 fabricated manifests, where a well-formed hash of the wrong file proves the two manifest assertions are not redundant; the all-baked reporting test verified to FAIL against a live-skillset environment. Reviewed mid-flight by pi@emb-7kj4vr4g over the logstream (correlation skillset-vendor-drift), which retracted its own earlier recommendation of a build-time byte-compare against skillset HEAD and supplied the better framing: the invariant is NON-CONTRADICTION, not currency. Byte parity on a fallback would have cost a resync commit plus a ~67-min base rebuild for each of the four skillset commits pushed in one evening. Its warning also found a real bug here: the script now CONSTRUCTS the snapshot from `git show HEAD:<path>` instead of copying the working tree, because a clean `git diff` says nothing about an untracked file — the one input the first draft would have recorded a false ref for. Tested: untracked, unstaged and staged-but-uncommitted all refuse, atomically. Also fixes three stale in-repo markers of the same class the canary belongs to (true when written, silently false at release): two dangling "Unreleased" pointers and a typst line still marked Unreleased five releases after v1.4.0.	2026-08-26 10:30:27 +02:00
pi	dbb78798fb	vendor: resync mempalace skill snapshot to skillset c04cd15 ... c04cd15 ('the withdrawal only holds where the bridge is live') landed after the v1.8.7 snapshot was taken, so the baked fallback was already 4 lines behind the skillset within hours of publishing. It adds the caveat this fleet is currently living in: the bridge is baked at image build, so a container on an image older than the stamping commit satisfies both env gates while stamping nothing, and hand-stamping is still the only signal a hand-filed drawer gets there. It also gives the one-line test — grep -c MEMPALACE_PI_DEVICE "$(readlink -f ~/.pi/agent/extensions/mempalace.ts)" which returns 0 on this v1.8.6 container, confirming the gap empirically. Note what this instance proves about the canary fixed one commit ago: it still PASSES on the refreshed copy, because both pinned phrases survived the edit. A phrase canary cannot detect 'older than skillset main' — only a diff can. This is the second drift in 24h and is the argument for the Still-open item (a CI job diffing this file against the skillset repo, blocked on a clone credential for a private repo). No re-pin was needed here.	2026-08-26 09:41:02 +02:00
pi	f645e6654f	smoke: fix the snapshot canary that blocked v1.8.7, and make it bidirectional ... Run 589 built the base cleanly and then failed both smoke jobs 81-passed/1-failed on 'mempalace skill snapshot is current'. That canary greps a phrase from the vendored mempalace skill to detect a stale snapshot, and the phrase it pinned was 'Attribute what you file yourself' — the heading of the hand-stamping instruction that THIS release withdraws. So it fired correctly: the snapshot changed and the expectation did not. Every publish job was skipped, so nothing reached the registry and v1.8.7 was never consumed. Rather than bump the string: * the assertion is now BIDIRECTIONAL — the new phrase must be present AND the withdrawn one absent. A one-way canary only catches half the drift: it cannot notice a re-vendored stale snapshot that happens to contain the pinned phrase. Verified against v1.8.6's snapshot, which now correctly fails. * the comment records the structural limit rather than just the fix: a phrase canary can only ever detect 'older than what I remembered to pin', never 'older than skillset main'. Only a diff against the skillset repo can do that, which is now a Still-open item — it needs a CI clone credential for a private repo, i.e. a policy decision, not a code change. Changelog consolidated: the SSH sidecar multiplexing default moves from Unreleased into v1.8.7, since the retag will sit on a commit that contains it, and the v1.8.7 summary now records the failed first attempt rather than quietly presenting the second one as the whole story. v1.8.7	2026-08-26 08:09:09 +02:00
pi	657b1ad856	ssh sidecar: default to multiplexing, as a default and not an override ... A target whose ~/.ssh/config entry never mentioned ControlMaster got no multiplexing from the sidecar (only ControlPath was supplied), so every ssh call opened a fresh TCP connection. On 2026-08-25 that produced ~12 connections to one host in 15 min and a fail2ban block that looked like an outage — the tell being that HTTPS to the same estate stayed healthy. The correctness of this depends entirely on WHERE the block goes. ssh_config is first-value-wins: ControlPath before the Include -> override (the user's value points at read-only ~/.ssh and cannot work in the container) ControlMaster after the Include -> default (an explicit per-host 'ControlMaster no' must keep winning) Force what is broken, default what is merely absent. The first draft put both in the leading block and would have silently overridden an explicit 'no'. Verified with ssh -G rather than from the man page, including the counterfactual: under the shipped layout an explicit 'no' resolves to controlmaster false while a silent host resolves to auto; under the rejected layout the 'no' host flips to auto. So the test discriminates position, not presence. Plus a sandbox render of the real script, bash -n, and shellcheck -S error (the v1.8.7 gate) clean. Effect measured on 41 real host aliases: 22 silent entries gain auto+10m, 0 overridden. Note the fleet's one deliberate opt-out is written as absence plus a comment ('# No ControlMaster — VPN means direct route'), which ssh cannot distinguish from no opinion; that host now multiplexes, which its own comment says is unnecessary rather than harmful. Skill documents the sidecar-vs-~/.ssh trap (the failure misleads: read-only ControlPath makes multiplexing look impossible rather than misconfigured) and the stale-master recovery, ssh -O check / -O exit.	2026-08-25 23:09:46 +02:00
pi	ebd0de0be2	changelog: v1.8.7 — device provenance reaches the fleet ... The provenance fix's client half lives in mempalace-toolkit, which the image clones at build time, so it only reaches the fleet through a tag. Records both routes (extension via MEMPALACE_TOOLKIT_REF folded into base_tag; vendored skill via rootfs), the three design points (stamp in the client not the agent; diary marker in TEXT because metadata is invisible to readers; solitary devbox stamps nothing), and why the allowlist is per tool (3.8.0 hard-fails -32602 on undeclared args). Carries the CI-hardening work already sitting in Unreleased, and a Still open block for the three known bounds.	2026-08-25 22:47:53 +02:00
pi	4f1aa0d0dd	skills: refresh the vendored mempalace snapshot (withdrawn hand-stamping) ... VENDORED.md's freshness model for `mempalace` is "Option 2 only — refreshed manually per release", and it had drifted since 2026-08-23. The stale snapshot still carried the instruction to hand-stamp added_by="<harness>@<device>", which skillset 73c7c8e withdrew: the pi bridge now stamps at the edge (mempalace-toolkit 553d865), and RFC 001 §7.3.2 ranks agent-side stamping ❌ worst-possible. That matters specifically for the fallback case this snapshot exists to serve — a container started WITHOUT the private skillset mounted would otherwise be the only kind of container still being taught to do it by hand.	2026-08-25 22:27:04 +02:00
joakimp	9e744d701f	lint: shellcheck the repo's own shell scripts, not just workflow run: steps ... lint.yml has shellchecked every workflow `run:` step since the dash-vs-bash incidents, but nothing had ever pointed shellcheck at entrypoint.sh, scripts/*.sh or the extensionless tools under rootfs/usr/local/bin/. That gap is not hypothetical: the skillset repo's ci-release-watcher template shipped `echo "$json" | python3 <<'EOF' ... json.load(sys.stdin)` for two months, where the heredoc IS python's stdin (no script arg) so the load hit EOF and the function silently returned nothing. shellcheck names exactly that at severity ERROR — SC2259, "This redirection overrides piped input" — and could have named it the whole time. New step in the existing actionlint job, so no second container pull: shellcheck -S error plus bash -n over every shell file, discovered as *.sh UNION a shebang scan (the glob alone misses pi-devbox-version, devbox-skill-reconcile, dot-watch and studio-expose; a shebang scan alone would miss a sourced fragment without one). Fails loudly on a zero-file match, because a green tick over an empty set is not a check. Severity chosen by measurement, not taste: -S error is 0 findings across all 11 shell files today, so the gate is green on arrival with no cleanup, while -S warning is NOT free (19x SC2088 tilde-in-quotes in recreate-sanity-check.sh plus assorted SC2016, all intentional) and would train everyone to ignore the job — the same reasoning as the SHELLCHECK_OPTS exclusions already on the actionlint step.	2026-08-25 21:11:55 +02:00